Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: sync TiDBSkipMissingPartitionStats value in the auto analyze (#60038) #60046

Open
wants to merge 2 commits into
base: release-7.1
Choose a base branch
from

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Mar 13, 2025

This is an automated cherry-pick of #60038

What problem does this PR solve?

Issue Number: close #60037

Problem Summary:

What changed and how does it work?

add test cases for auto analyze's tidb_skip_missing_partition_stats

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

sync TiDBSkipMissingPartitionStats value in the auto analyze

auto analyze 中同步TiDBSkipMissingPartitionStats 的值

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Mar 13, 2025
@ti-chi-bot
Copy link
Member Author

@hawkingrei This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

Copy link

ti-chi-bot bot commented Mar 13, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hawkingrei hawkingrei changed the title planner: add test cases for auto analyze's tidb_skip_missing_partition_stats (#60038) statistics: update TiDBSkipMissingPartitionStats value in the UpdateSessionVar (#60038) Mar 13, 2025
@hawkingrei hawkingrei force-pushed the cherry-pick-60038-to-release-7.1 branch from 7e4996e to 54a4747 Compare March 13, 2025 06:33
Copy link

ti-chi-bot bot commented Mar 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hawkingrei, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hawkingrei hawkingrei changed the title statistics: update TiDBSkipMissingPartitionStats value in the UpdateSessionVar (#60038) statistics: sync TiDBSkipMissingPartitionStats value in the auto analyze (#60038) Mar 13, 2025
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 13, 2025
@hawkingrei
Copy link
Member

/retest

Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2025
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.1@350b4a8). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #60046   +/-   ##
================================================
  Coverage               ?   73.4781%           
================================================
  Files                  ?       1213           
  Lines                  ?     382160           
  Branches               ?          0           
================================================
  Hits                   ?     280804           
  Misses                 ?      83418           
  Partials               ?      17938           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants