Lightning: testcase avoid using go units. #60060

OliverS929 · 2025-03-13T08:47:48Z

What problem does this PR solve?

Issue Number: close #60059

See also:
e92a92f#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6
https://pkg.go.dev/github.com/docker/go-units?utm_source=godoc

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot · 2025-03-13T08:47:54Z

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

It must be approved by the approvers firstly.
AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-03-13T08:48:07Z

Hi @OliverS929. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

OliverS929 · 2025-03-13T08:48:10Z

/ok-to-test

codecov · 2025-03-13T08:59:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.5@1ad553d). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-7.5     #60060   +/-   ##
================================================
  Coverage               ?   72.1668%           
================================================
  Files                  ?       1417           
  Lines                  ?     414057           
  Branches               ?          0           
================================================
  Hits                   ?     298812           
  Misses                 ?      95221           
  Partials               ?      20024

Flag	Coverage Δ
unit	`72.1668% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9400% <0.0000%> (?)`
parser	`∅ <0.0000%> (?)`
br	`53.5611% <0.0000%> (?)`

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

OliverS929 · 2025-03-13T09:03:10Z

/affect 7.5.5

stevenayu · 2025-03-13T09:07:12Z

/test ?

ti-chi-bot · 2025-03-13T09:07:18Z

@stevenayu: The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test unit-test

The following commands are available to trigger optional jobs:

/test pull-br-integration-test

/test pull-common-test

/test pull-e2e-test

/test pull-integration-binlog-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-ddl-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-integration-tidb-tools-test

/test pull-mysql-client-test

/test pull-sqllogic-test

/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/release-7.5/ghpr_build

pingcap/tidb/release-7.5/ghpr_check

pingcap/tidb/release-7.5/ghpr_check2

pingcap/tidb/release-7.5/ghpr_mysql_test

pingcap/tidb/release-7.5/ghpr_unit_test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-03-13T09:07:37Z

@stevenayu: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

stevenayu · 2025-03-13T09:07:43Z

/test pull-br-integration-test

tiprow · 2025-03-13T09:07:44Z

@ti-chi-bot[bot]: No presubmit jobs available for pingcap/[email protected]

In response to this:

@stevenayu: The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test unit-test
The following commands are available to trigger optional jobs:
/test pull-br-integration-test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-binlog-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-integration-tidb-tools-test
/test pull-mysql-client-test
/test pull-sqllogic-test
/test pull-tiflash-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/release-7.5/ghpr_build
pingcap/tidb/release-7.5/ghpr_check
pingcap/tidb/release-7.5/ghpr_check2
pingcap/tidb/release-7.5/ghpr_mysql_test
pingcap/tidb/release-7.5/ghpr_unit_test
In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-03-13T09:08:09Z

@stevenayu: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

River2000i · 2025-03-13T09:41:09Z

/LGTM

ti-chi-bot · 2025-03-13T09:41:20Z

@River2000i: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

stevenayu · 2025-03-13T09:51:55Z

/retest

Benjamin2037

LGTM

ti-chi-bot · 2025-03-13T10:55:21Z

[LGTM Timeline notifier]

Timeline:

2025-03-13 10:54:27.091629061 +0000 UTC m=+439622.697157988: ☑️ agreed by joccau.
2025-03-13 10:55:20.277814842 +0000 UTC m=+439675.883343768: ☑️ agreed by Benjamin2037.

ti-chi-bot · 2025-03-13T14:30:34Z

@RidRisR: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2025-03-13T14:44:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Benjamin2037, joccau, RidRisR, River2000i

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~br/OWNERS~~ [3pointer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Lightning test: avoid using go units.

3b444bf

ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2025

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Mar 13, 2025

joccau approved these changes Mar 13, 2025

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 13, 2025

Benjamin2037 approved these changes Mar 13, 2025

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 13, 2025

RidRisR approved these changes Mar 13, 2025

View reviewed changes

3pointer approved these changes Mar 13, 2025

View reviewed changes

ti-chi-bot bot added the approved label Mar 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lightning: testcase avoid using go units. #60060

Lightning: testcase avoid using go units. #60060

OliverS929 commented Mar 13, 2025 •

edited

Loading

ti-chi-bot bot commented Mar 13, 2025

tiprow bot commented Mar 13, 2025

OliverS929 commented Mar 13, 2025

codecov bot commented Mar 13, 2025 •

edited

Loading

OliverS929 commented Mar 13, 2025

stevenayu commented Mar 13, 2025

ti-chi-bot bot commented Mar 13, 2025

tiprow bot commented Mar 13, 2025

stevenayu commented Mar 13, 2025

tiprow bot commented Mar 13, 2025

tiprow bot commented Mar 13, 2025

River2000i commented Mar 13, 2025

ti-chi-bot bot commented Mar 13, 2025

stevenayu commented Mar 13, 2025

Benjamin2037 left a comment

ti-chi-bot bot commented Mar 13, 2025

ti-chi-bot bot commented Mar 13, 2025

ti-chi-bot bot commented Mar 13, 2025

Lightning: testcase avoid using go units. #60060

Are you sure you want to change the base?

Lightning: testcase avoid using go units. #60060

Conversation

OliverS929 commented Mar 13, 2025 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Mar 13, 2025

tiprow bot commented Mar 13, 2025

OliverS929 commented Mar 13, 2025

codecov bot commented Mar 13, 2025 • edited Loading

Codecov Report

OliverS929 commented Mar 13, 2025

stevenayu commented Mar 13, 2025

ti-chi-bot bot commented Mar 13, 2025

tiprow bot commented Mar 13, 2025

stevenayu commented Mar 13, 2025

tiprow bot commented Mar 13, 2025

tiprow bot commented Mar 13, 2025

River2000i commented Mar 13, 2025

ti-chi-bot bot commented Mar 13, 2025

stevenayu commented Mar 13, 2025

Benjamin2037 left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Mar 13, 2025

[LGTM Timeline notifier]

ti-chi-bot bot commented Mar 13, 2025

ti-chi-bot bot commented Mar 13, 2025

OliverS929 commented Mar 13, 2025 •

edited

Loading

codecov bot commented Mar 13, 2025 •

edited

Loading