Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix data race in the join.(*hashJoinSpillHelper).generateSpilledValidJoinKey() #60061

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xzhangxian1008
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #60052

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2025
Copy link

tiprow bot commented Mar 13, 2025

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xzhangxian1008 xzhangxian1008 changed the title Fix data race in the join.(*hashJoinSpillHelper).generateSpilledValidJoinKey() executor: fix data race in the join.(*hashJoinSpillHelper).generateSpilledValidJoinKey() Mar 13, 2025
Copy link

ti-chi-bot bot commented Mar 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 13, 2025
Copy link

ti-chi-bot bot commented Mar 13, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-13 08:59:21.308457365 +0000 UTC m=+432716.913986287: ☑️ agreed by hawkingrei.

@xzhangxian1008
Copy link
Contributor Author

/cc @yibin87

@ti-chi-bot ti-chi-bot bot requested a review from yibin87 March 13, 2025 08:59
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.5573%. Comparing base (9e61bd2) to head (68cb460).
Report is 2 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60061        +/-   ##
================================================
+ Coverage   73.1192%   73.5573%   +0.4381%     
================================================
  Files          1706       1706                
  Lines        471381     471421        +40     
================================================
+ Hits         344670     346765      +2095     
+ Misses       105502     103476      -2026     
+ Partials      21209      21180        -29     
Flag Coverage Δ
integration 42.9200% <25.0000%> (?)
unit 72.3407% <75.0000%> (+0.0279%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 47.1990% <ø> (+0.0055%) ⬆️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hawkingrei
Copy link
Member

/check-issue-triage-complete

@xzhangxian1008
Copy link
Contributor Author

/retest

@xzhangxian1008
Copy link
Contributor Author

/cc @yibin87

Copy link

tiprow bot commented Mar 13, 2025

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DATA RACE in the join.(*hashJoinSpillHelper).generateSpilledValidJoinKey()
2 participants