Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support other integer types for SubstringUTF8 & RightUTF8 functions (#9507) #9512

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Support other integer types for SubstringUTF8 & RightUTF8 functions (#9507) #9512

merged 1 commit into from
Feb 6, 2025

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9507

What problem does this PR solve?

Issue Number: close #9473

Problem Summary:

What is changed and how it works?

Support other integer types for SubstringUTF8 & RightUTF8 functions

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Oct 10, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 10, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 21, 2025
@gengliqi gengliqi force-pushed the cherry-pick-9507-to-release-6.5 branch from 5c9a01f to a2c65a7 Compare February 5, 2025 09:49
@ti-chi-bot @gengliqi
Support other integer types for SubstringUTF8 & RightUTF8 functions (p…
d301812 
…ingcap#9507) (pingcap#9513)

close pingcap#9473

Support other integer types for SubstringUTF8 & RightUTF8 functions

Signed-off-by: gengliqi <[email protected]>
@gengliqi gengliqi force-pushed the cherry-pick-9507-to-release-6.5 branch from 838265d to d301812 Compare February 5, 2025 10:02
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 5, 2025
yibin87
yibin87 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 6, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-05 10:03:20.445952619 +0000 UTC m=+266071.978364614: ☑️ agreed by gengliqi.
  • 2025-02-06 02:48:20.272761351 +0000 UTC m=+326371.805173333: ☑️ agreed by yibin87.

@ti-chi-bot ti-chi-bot bot merged commit ca5927a into pingcap:release-6.5 Feb 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yibin87 yibin87 yibin87 approved these changes

@gengliqi gengliqi gengliqi approved these changes

Assignees

@gengliqi gengliqi

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @yibin87 @gengliqi