Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puller: fix a bug that may cause error when replicate truncate table ddl #11772

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Nov 19, 2024

What problem does this PR solve?

Issue Number: close #11765

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from asddongmen, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 19, 2024
@asddongmen asddongmen marked this pull request as draft November 19, 2024 03:29
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2024
@asddongmen
Copy link
Contributor Author

/test all

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.1708%. Comparing base (6fc5a49) to head (ecd1a3a).
Report is 47 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 59.5992% <100.0000%> (-1.6109%) ⬇️
dm 50.0654% <ø> (-0.9801%) ⬇️
engine 53.2167% <ø> (-10.1572%) ⬇️
Flag Coverage Δ
unit 55.1708% <100.0000%> (-2.2954%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11772        +/-   ##
================================================
- Coverage   57.4662%   55.1708%   -2.2954%     
================================================
  Files           851       1002       +151     
  Lines        126462     137404     +10942     
================================================
+ Hits          72673      75807      +3134     
- Misses        48389      56056      +7667     
- Partials       5400       5541       +141     
---- 🚨 Try these New Features:

Copy link
Contributor

ti-chi-bot bot commented Nov 19, 2024

@asddongmen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-storage-test ecd1a3a link true /test cdc-integration-storage-test
pull-cdc-integration-mysql-test ecd1a3a link true /test cdc-integration-mysql-test
pull-cdc-integration-kafka-test ecd1a3a link true /test cdc-integration-kafka-test
pull-cdc-integration-pulsar-test ecd1a3a link true /test cdc-integration-pulsar-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

truncate table of ineligible table is not ignored
1 participant