Update SearchRequestBuilder#invoke processing. #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the SearchRequestBuilder's parsing of ListResponses returned from SCIM services to be permissive of improperly-cased attributes in the response (e.g., "resources" instead of "Resources"). This is intended to broaden compatibility. This change includes: * Documentation updates to give more information about SearchRequests. * Simplify the invoke() logic by including try-with-resources blocks. Reviewer: vyhhuang Reviewer: dougbulkley JiraIssue: DS-49756
dougbulkley
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
I got confused by your statement:
"...to be permissive of improperly-cased attributes in the response...."
You do give an example, but without looking at the code I assumed it meant all attributes, not just a select few, maybe that is worth mentioning to save confusion, or maybe not. Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the SearchRequestBuilder's parsing of ListResponses returned from SCIM services to be permissive of improperly-cased attributes in the response (e.g., "resources" instead of "Resources"). This is intended to broaden compatibility.
This change includes:
Reviewer: vyhhuang
Reviewer: dougbulkley
JiraIssue: DS-49756
Resolves #97
Resolves #150