-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing issue "The Android Gradle plugin supports only Kotlin Gradle plugin version 1.5.20 and higher." #48
Fixing issue "The Android Gradle plugin supports only Kotlin Gradle plugin version 1.5.20 and higher." #48
Conversation
• Update gradle version to 4.2.2 • Update target and compile sdk to 33 • Move from jcenter() to mavenCentral()
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version" | ||
} | ||
} | ||
|
||
allprojects { | ||
repositories { | ||
google() | ||
jcenter() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, it still referred to jcenter? Wow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, it still referred to jcenter? Wow.
Yeah, this package needs to be updated.
For anyone being held up here's how to use this commit.
It doesn't look like this is actively maintained, if someone could launch a new package on pub that would be helpful! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appprove it!
@@ -2,14 +2,15 @@ group 'com.whelksoft.flutter_native_timezone' | |||
version '1.0-SNAPSHOT' | |||
|
|||
buildscript { | |||
ext.kotlin_version = '1.3.50' | |||
ext.kotlin_version = '1.6.10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just trying if I can approve this as an outsider...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just trying if I can approve this as an outsider...
Unfortunately it can't :(
Due to lack of maintenance in this repo, I have just published a fork on pub.dev. I have taken the liberty of cherry-picking the commits in this branch into that fork. |
since I can't run my app with this library because of the version issues, so @pinkfish I think this pr should be merged to be able to be used by many users. |
@tjarvstrand So you plan on maintaining it? |
@larssn Yes, that's the idea. I don't have a ton of time to invest but I'll do my best and I don't really expect there to be that much effort involved :) |
Probably not no. Your biggest headacre will be saying no to weird PR's that does stuff no one asked for. 🙂 |
And fix #49 |
Fixing issue #47
Change list