Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue "The Android Gradle plugin supports only Kotlin Gradle plugin version 1.5.20 and higher." #48

Closed
wants to merge 3 commits into from

Conversation

baharudin-yusup
Copy link

Fixing issue #47

Change list

  • Update kotlin version to 1.6.10
  • Update gradle version to 7.2
  • Update target and compile sdk to 33
  • Move from jcenter() to mavenCentral()

• Update gradle version to 4.2.2
• Update target and compile sdk to 33
• Move from jcenter() to mavenCentral()
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
}
}

allprojects {
repositories {
google()
jcenter()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, it still referred to jcenter? Wow.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, it still referred to jcenter? Wow.

Yeah, this package needs to be updated.

@CalHoll
Copy link

CalHoll commented Nov 7, 2022

For anyone being held up here's how to use this commit.

flutter_native_timezone: 
    git:
      url: https://github.com/baharudin-yusup/flutter_native_timezone.git
      ref: e975c46ecb481dd67c98f1832f13df83776d8521

It doesn't look like this is actively maintained, if someone could launch a new package on pub that would be helpful!

Copy link

@MrCsabaToth MrCsabaToth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appprove it!

@@ -2,14 +2,15 @@ group 'com.whelksoft.flutter_native_timezone'
version '1.0-SNAPSHOT'

buildscript {
ext.kotlin_version = '1.3.50'
ext.kotlin_version = '1.6.10'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just trying if I can approve this as an outsider...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just trying if I can approve this as an outsider...

Unfortunately it can't :(

@tjarvstrand
Copy link

Due to lack of maintenance in this repo, I have just published a fork on pub.dev.

I have taken the liberty of cherry-picking the commits in this branch into that fork.

@icgoogo
Copy link

icgoogo commented Dec 30, 2022

since I can't run my app with this library because of the version issues, so @pinkfish I think this pr should be merged to be able to be used by many users.

@larssn
Copy link

larssn commented Jan 2, 2023

@tjarvstrand So you plan on maintaining it?

@tjarvstrand
Copy link

@larssn Yes, that's the idea. I don't have a ton of time to invest but I'll do my best and I don't really expect there to be that much effort involved :)

@larssn
Copy link

larssn commented Jan 2, 2023

@larssn Yes, that's the idea. I don't have a ton of time to invest but I'll do my best and I don't really expect there to be that much effort involved :)

Probably not no. Your biggest headacre will be saying no to weird PR's that does stuff no one asked for. 🙂

@guyluz11
Copy link

guyluz11 commented Jan 9, 2023

And fix #49

@baharudin-yusup baharudin-yusup closed this by deleting the head repository Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants