Skip to content

Commit

Permalink
Added unit tests to verify short circuit logic
Browse files Browse the repository at this point in the history
  • Loading branch information
@maallen
maallen committed Aug 10, 2023
1 parent e4960ca commit c6ba65d
Showing 1 changed file with 265 additions and 0 deletions.
265 changes: 265 additions & 0 deletions webapp/src/test/java/com/box/l10n/mojito/service/thirdparty/ThirdPartyTMSSmartlingTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1213,6 +1213,271 @@ public void testPullDryRunNoBatches() throws RepositoryLocaleCreationException {
.importTextUnits(textUnitListCaptor.capture(), eq(false), eq(true));
}

@Test
public void testPullShortCircuitIfNoChangesInTranslatedFiles()
throws RepositoryNameAlreadyUsedException, RepositoryLocaleCreationException {

int batchSize = 3;
List<TextUnitDTO> tus;
List<Locale> locales = new ArrayList<>();
Map<String, String> localeMapping = Collections.emptyMap();
tmsSmartling =
new ThirdPartyTMSSmartling(
smartlingClient,
textUnitSearcher,
assetPathAndTextUnitNameKeys,
mockTextUnitBatchImporterService,
resultProcessor,
mockThirdPartyTMSSmartlingWithJson,
mockThirdPartyTMSSmartlingGlossary,
assetTextUnitToTMTextUnitRepository,
batchSize,
meterRegistry,
mockThirdPartyFileChecksumRepository);
Repository repository =
repositoryService.createRepository(testIdWatcher.getEntityName("batchRepo"));
Locale frCA = localeService.findByBcp47Tag("fr-CA");
Locale jaJP = localeService.findByBcp47Tag("ja-JP");
repositoryService.addRepositoryLocale(repository, frCA.getBcp47Tag());
repositoryService.addRepositoryLocale(repository, jaJP.getBcp47Tag());
locales.add(frCA);
locales.add(jaJP);

TM tm = repository.getTm();
Asset asset =
assetService.createAssetWithContent(repository.getId(), "fake_for_test", "fake for test");
AssetExtraction assetExtraction = new AssetExtraction();
assetExtraction.setAsset(asset);
assetExtraction = assetExtractionRepository.save(assetExtraction);

PluralForm one = pluralFormService.findByPluralFormString("one");

List<Long> singularIds = new ArrayList<>();
int singularTextUnits = 14;
int singularBatches = 5;

for (int i = 0; i < singularTextUnits; i++) {
String name = "singular_message_test" + i;
String content = "Singular Message Test #" + i;
String comment = "Singular Comment" + i;
TMTextUnit textUnit =
tmService.addTMTextUnit(tm.getId(), asset.getId(), name, content, comment);
singularIds.add(textUnit.getId());
assetExtractionService.createAssetTextUnit(assetExtraction, name, content, comment);
}

List<Long> pluralIds = new ArrayList<>();
int pluralTextUnits = 8;
int pluralBatches = 3;

for (int i = 0; i < pluralTextUnits; i++) {
String name = "plural_message" + i + "_one";
String content = "Plural Message Test #" + i;
String comment = "Plural Comment" + i;
String pluralFormOther = "plural_form_other" + i;

TMTextUnit textUnit =
tmService.addTMTextUnit(tm, asset, name, content, comment, null, one, pluralFormOther);
pluralIds.add(textUnit.getId());
assetExtractionService.createAssetTextUnit(assetExtraction, name, content, comment);
}

prepareAssetAndTextUnits(assetExtraction, asset, tm);

tus = searchTextUnits(singularIds);
Iterable<List<TextUnitDTO>> singularIt = Iterables.partition(tus, batchSize);
int i = 0;
for (List<TextUnitDTO> textUnits : singularIt) {
for (Locale l : locales) {
doReturn(localizedContent(textUnits, l))
.when(smartlingClient)
.downloadPublishedFile(
eq("projectId"),
eq(l.getBcp47Tag()),
eq(singularFileName(repository, i)),
eq(false));
}
i++;
}

tus = searchTextUnits(pluralIds);
Iterable<List<TextUnitDTO>> pluralIt = Iterables.partition(tus, batchSize);
i = 0;
for (List<TextUnitDTO> textUnits : pluralIt) {
for (Locale l : locales) {
doReturn(localizedContent(textUnits, l))
.when(smartlingClient)
.downloadPublishedFile(
eq("projectId"), eq(l.getBcp47Tag()), eq(pluralFileName(repository, i)), eq(false));
}
i++;
}

// Execute an initial pull that will record translated files checksums and verify text units are
// imported
tmsSmartling.pull(
repository, "projectId", pluralSep, localeMapping, null, null, Collections.emptyList());

verify(mockTextUnitBatchImporterService, atLeastOnce())
.importTextUnits(textUnitListCaptor.capture(), eq(false), eq(true));

Mockito.clearInvocations(mockTextUnitBatchImporterService);

// Now run the same pull again, text unit imports should be skipped as file checksums from
// previous run exist and match.
tmsSmartling.pull(
repository, "projectId", pluralSep, localeMapping, null, null, Collections.emptyList());

verify(mockTextUnitBatchImporterService, times(0))
.importTextUnits(textUnitListCaptor.capture(), eq(false), eq(true));
}

@Test
public void testPullShortCircuitIfChangesInTranslatedFiles()
throws RepositoryNameAlreadyUsedException, RepositoryLocaleCreationException {

int batchSize = 3;
List<TextUnitDTO> tus;
List<Locale> locales = new ArrayList<>();
Map<String, String> localeMapping = Collections.emptyMap();
tmsSmartling =
new ThirdPartyTMSSmartling(
smartlingClient,
textUnitSearcher,
assetPathAndTextUnitNameKeys,
mockTextUnitBatchImporterService,
resultProcessor,
mockThirdPartyTMSSmartlingWithJson,
mockThirdPartyTMSSmartlingGlossary,
assetTextUnitToTMTextUnitRepository,
batchSize,
meterRegistry,
mockThirdPartyFileChecksumRepository);
Repository repository =
repositoryService.createRepository(testIdWatcher.getEntityName("batchRepo"));
Locale frCA = localeService.findByBcp47Tag("fr-CA");
Locale jaJP = localeService.findByBcp47Tag("ja-JP");
repositoryService.addRepositoryLocale(repository, frCA.getBcp47Tag());
repositoryService.addRepositoryLocale(repository, jaJP.getBcp47Tag());
locales.add(frCA);
locales.add(jaJP);

TM tm = repository.getTm();
Asset asset =
assetService.createAssetWithContent(repository.getId(), "fake_for_test", "fake for test");
AssetExtraction assetExtraction = new AssetExtraction();
assetExtraction.setAsset(asset);
assetExtraction = assetExtractionRepository.save(assetExtraction);

PluralForm one = pluralFormService.findByPluralFormString("one");

List<Long> singularIds = new ArrayList<>();
int singularTextUnits = 14;
int singularBatches = 5;

for (int i = 0; i < singularTextUnits; i++) {
String name = "singular_message_test" + i;
String content = "Singular Message Test #" + i;
String comment = "Singular Comment" + i;
TMTextUnit textUnit =
tmService.addTMTextUnit(tm.getId(), asset.getId(), name, content, comment);
singularIds.add(textUnit.getId());
assetExtractionService.createAssetTextUnit(assetExtraction, name, content, comment);
}

List<Long> pluralIds = new ArrayList<>();
int pluralTextUnits = 8;
int pluralBatches = 3;

for (int i = 0; i < pluralTextUnits; i++) {
String name = "plural_message" + i + "_one";
String content = "Plural Message Test #" + i;
String comment = "Plural Comment" + i;
String pluralFormOther = "plural_form_other" + i;

TMTextUnit textUnit =
tmService.addTMTextUnit(tm, asset, name, content, comment, null, one, pluralFormOther);
pluralIds.add(textUnit.getId());
assetExtractionService.createAssetTextUnit(assetExtraction, name, content, comment);
}

prepareAssetAndTextUnits(assetExtraction, asset, tm);

tus = searchTextUnits(singularIds);
Iterable<List<TextUnitDTO>> singularIt = Iterables.partition(tus, batchSize);
int i = 0;
for (List<TextUnitDTO> textUnits : singularIt) {
for (Locale l : locales) {
doReturn(localizedContent(textUnits, l))
.when(smartlingClient)
.downloadPublishedFile(
eq("projectId"),
eq(l.getBcp47Tag()),
eq(singularFileName(repository, i)),
eq(false));
}
i++;
}

tus = searchTextUnits(pluralIds);
Iterable<List<TextUnitDTO>> pluralIt = Iterables.partition(tus, batchSize);
i = 0;
for (List<TextUnitDTO> textUnits : pluralIt) {
for (Locale l : locales) {
doReturn(localizedContent(textUnits, l))
.when(smartlingClient)
.downloadPublishedFile(
eq("projectId"), eq(l.getBcp47Tag()), eq(pluralFileName(repository, i)), eq(false));
}
i++;
}

// Execute an initial pull that will record translated files checksums and verify text units are
// imported
tmsSmartling.pull(
repository, "projectId", pluralSep, localeMapping, null, null, Collections.emptyList());

verify(mockTextUnitBatchImporterService, atLeastOnce())
.importTextUnits(textUnitListCaptor.capture(), eq(false), eq(true));

Mockito.clearInvocations(mockTextUnitBatchImporterService);

i = 0;
for (List<TextUnitDTO> textUnits : singularIt) {
for (Locale l : locales) {
// add a new line to translated file to trigger checksum change
doReturn(localizedContent(textUnits, l) + "\n")
.when(smartlingClient)
.downloadPublishedFile(
eq("projectId"),
eq(l.getBcp47Tag()),
eq(singularFileName(repository, i)),
eq(false));
}
i++;
}

i = 0;
for (List<TextUnitDTO> textUnits : pluralIt) {
for (Locale l : locales) {
// add a new line to translated file to trigger checksum change
doReturn(localizedContent(textUnits, l) + "\n")
.when(smartlingClient)
.downloadPublishedFile(
eq("projectId"), eq(l.getBcp47Tag()), eq(pluralFileName(repository, i)), eq(false));
}
i++;
}

// Run the same pull again, text unit imports should occur as file checksums have changed since
// previous run
tmsSmartling.pull(
repository, "projectId", pluralSep, localeMapping, null, null, Collections.emptyList());

verify(mockTextUnitBatchImporterService, atLeastOnce())
.importTextUnits(textUnitListCaptor.capture(), eq(false), eq(true));
}

@Test
public void testPullInBatchesWithSingularsAndPlurals()
throws RepositoryNameAlreadyUsedException, RepositoryLocaleCreationException {
Expand Down

0 comments on commit c6ba65d

Please sign in to comment.