Orion Broker Set UI Implementation #292
Conversation
| private List<List<Integer>> brokersetRanges = new ArrayList<>(); | ||
| private List<String> brokerIds; |
There was a problem hiding this comment.
Are we keeping redundant information in these two variables? Isn't brokerIds union of all brokersetRanges?
There was a problem hiding this comment.
The ranges are from the configuration. The ids are from the cluster info.
There can be a condition that brokerRange contains a broker that does not exist. Now, that means the brokerset is invalid. Once we have more condition check, there can be other reasons causing this mismatch.
Will add comments for these two variables along with other changes.
| return brokersetStatus; | ||
| } | ||
|
|
||
| function getStatusColumns() { |
There was a problem hiding this comment.
Should this be getStatsColumns columns? Are there other places a similar change if needed?
There was a problem hiding this comment.
For brokerset, do we want to use stats or status? I want to display the condition of a brokerset at one time.
https://stackoverflow.com/questions/1162816/naming-conventions-state-versus-status
Code Review Summary: Orion Broker Set UI Implementation
Enhancements to Broker Set Section on Service Page
Improvements to Node Page
Class Updates
The existing
BrokerSetclass is generated from a configuration file every 2 minutes, which means it cannot currently save state information. Additionally, it plays a critical role in the existing topic assignment logic. To avoid disrupting any existing logic during refactoring, a newBrokerSetStateclass has been added.Testing
This change has been tested via branch deployment.