fix: schema filtering in table search modal (#1348)

* fix: schema filtering for table search * revert unnecessary changes
pinterest · Feb 27, 2024 · 4d41106 · 4d41106
1 parent 8190652
commit 4d41106
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 16 deletions.
diff --git a/querybook/webapp/components/Search/SearchOverview.tsx b/querybook/webapp/components/Search/SearchOverview.tsx
@@ -775,6 +775,7 @@ export const SearchOverview: React.FC<ISearchOverviewProps> = ({
                     <SearchSchemaSelect
                         updateSearchFilter={updateSearchFilter}
                         schema={searchFilters?.schema}
+                        metastoreId={metastoreId}
                     />
                 </div>
                 {queryMetastoreHasDataElements && (

diff --git a/querybook/webapp/components/Search/SearchSchemaSelect.tsx b/querybook/webapp/components/Search/SearchSchemaSelect.tsx
@@ -1,7 +1,5 @@
 import React, { useMemo, useCallback } from 'react';
 import AsyncSelect from 'react-select/async';
-import { useSelector } from 'react-redux';
-import { IStoreState } from 'redux/store/types';
 import {
     makeReactSelectStyle,
     asyncReactSelectStyles,
@@ -10,6 +8,7 @@ import {
 import { SearchSchemaResource } from 'resource/search';
 
 interface ISearchSchemaSelectProps {
+    metastoreId: number;
     schema?: string[];
     updateSearchFilter: (key: string, value: string[]) => void;
 }
@@ -22,29 +21,29 @@ const tableReactSelectStyle = makeReactSelectStyle(
 export const SearchSchemaSelect: React.FC<ISearchSchemaSelectProps> = ({
     updateSearchFilter,
     schema,
+    metastoreId,
 }) => {
-    const currentMetastoreId = useSelector(
-        (state: IStoreState) => state.environment.currentEnvironmentId
-    );
-
     const handleUpdateSearchFilter = useCallback((option: IOptions<string>) => {
         updateSearchFilter(
             'schema',
             option.map((o) => o.value)
         );
     }, []);
 
-    const loadOptions = useCallback(async (value) => {
-        const searchRequest = await SearchSchemaResource.getMore({
-            metastore_id: currentMetastoreId,
-            name: value,
-        });
+    const loadOptions = useCallback(
+        async (value) => {
+            const searchRequest = await SearchSchemaResource.getMore({
+                metastore_id: metastoreId,
+                name: value,
+            });
 
-        return searchRequest.data.results.map((schema) => ({
-            label: schema.name,
-            value: schema.name,
-        }));
-    }, []);
+            return searchRequest.data.results.map((schema) => ({
+                label: schema.name,
+                value: schema.name,
+            }));
+        },
+        [metastoreId, schema]
+    );
 
     const selectedSchemaItems = useMemo(
         () =>