feat: Added button to execute all query cells in a datadoc after the current cell #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @jij1949 thanks for the PR. |
czgu
reviewed
Aug 25, 2023
jczhong84
reviewed
Aug 28, 2023
querybook/webapp/components/DataDocQueryCell/DataDocQueryCell.tsx
Outdated
Show resolved
Hide resolved
…and from all from here buttons
jczhong84
reviewed
Feb 25, 2024
| docId, | ||
| queryIndexInDoc | ||
| ); | ||
| console.log(onRunAllFromIndex); |
Comment on lines
+34
to
+36
| if (index !== undefined) { | ||
| queryCells = queryCells.slice(index); | ||
| } |
There was a problem hiding this comment.
is this the index of the query cell in the datadoc, including text cells? e.g. what if there is a text cell before the starting query cell, is the slicing still correct?
same for the start_index in the above .py file, please double confirm
|
|
||
| export function useRunAllFromIndex(docId: number, index?: number) { | ||
| const header = | ||
| index === undefined ? 'Run All Cells' : 'Run all cells below'; |
There was a problem hiding this comment.
please keep the case consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds an additional run button for each query cell which will execute that query cell along with all of the query cells below it in the datadoc. As a user, when a time-consuming datadoc execution crashes, I want to be able to pick up the execution where it left off in order to avoid running the cells that already executed again. This new button allows the user to continue the datadoc execution from the specific cell where the execution crashed before.