Multiple Editor Style Changes #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
czgu
commented
Nov 19, 2024
czgu
commented
- Updated monokai style so the default text is white instead of orange
- Added per language keyword config
- Altered indent rule for something simpler: it just indent based on the previous line indent level.
jczhong84
reviewed
Nov 19, 2024
Comment on lines
297
to
298
| metastoreId: 1, | ||
| language, |
There was a problem hiding this comment.
can you help to update the hardcoded metastoreId above as well? thanks!
jczhong84
reviewed
Nov 19, 2024
| @@ -293,6 +295,7 @@ export const QueryEditor: React.FC< | |||
| useHoverTooltipExtension({ | |||
| codeAnalysisRef, | |||
| metastoreId: 1, | |||
There was a problem hiding this comment.
Suggested change
| metastoreId: 1, | |
| metastoreId, |
jczhong84
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.