Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AZ Header to Kafka Logs #343

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Add AZ Header to Kafka Logs #343

merged 2 commits into from
Sep 7, 2023

Conversation

e-v-nguyen
Copy link
Contributor

@e-v-nguyen e-v-nguyen commented Sep 7, 2023 •
edited
Loading

  • Tested with unit tests to ensure "availabilityZone: "us-east-1a" shows up in log msgs to kafka.
    mvn test -pl singer -am passes
  • Tested in devapp w/ thrift logs and text logs, and each of those with and without EC2 env set.
    If EC2 env is set, "availabilityZone: "us-east-1a".
    Else env is not set, "availabilityZone: "n/a".

@e-v-nguyen e-v-nguyen requested a review from a team as a code owner September 7, 2023 18:18
@jfzunigac
Copy link
Contributor

LGTM, can you also bump the version to 0.8.0.77?

@jfzunigac jfzunigac merged commit a8b0966 into pinterest:master Sep 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfzunigac jfzunigac jfzunigac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-v-nguyen @jfzunigac