Use atomic to avoid stale SRTP protection profile #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`state` is acccessed without lock in the FSM. In some cases, that leads to stale values. For example, `srtpProtectionProfile` is set in flight handlers (differnt flight handlers in client and server). But, when it is accessed via the API `SelectedSRTPProtectionProfile`, it gets a stale value as it appears that the two goroutines are out-of-sync on that piece of shared memory. This is a larger concern for use of `state`. Ideally, either - `state` should have a lock internally and all fields are accessed through methods. - carefully split fields of `state` to ensure process access/sync. Doing the smaller change here to address one field that has seen stale value.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #595 +/- ##
==========================================
+ Coverage 77.66% 77.71% +0.04%
==========================================
Files 101 101
Lines 6430 6435 +5
==========================================
+ Hits 4994 5001 +7
+ Misses 1060 1057 -3
- Partials 376 377 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stateis acccessed without lock in the FSM.In some cases, that leads to stale values.
For example,
srtpProtectionProfileis set in flight handlers (differnt flight handlers in client and server). But, when it is accessed via the APISelectedSRTPProtectionProfile,it gets a stale value as it appears that the two goroutines are out-of-sync on that piece of shared memory.
This is a larger concern for use of
state.Ideally, either
stateshould have a lock internally and all fields are accessed through methods.stateto ensure process access/sync.Doing the smaller change here to address one field that has seen stale value.