Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transceivers state change from inactive to active #2426

Closed
wants to merge 2 commits into from

Conversation

zjzhang-cn
Copy link
Member

Description

Reuse transceivers in remote peer。

In the existing RTC Transceivers, when the state of the remote transceiver changes from inactive to active, the state of the pion also needs to change from inactive to active。

Reference issue

Fixes #...

…anges from inactive to active, the state of the pion also needs to change from inactive to active
@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Attention: Patch coverage is 34.21053% with 25 lines in your changes missing coverage. Please review.

Project coverage is 77.45%. Comparing base (61f69be) to head (cc4f788).
Report is 321 commits behind head on master.

Files with missing lines Patch % Lines
peerconnection.go 34.21% 22 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2426      +/-   ##
==========================================
- Coverage   77.52%   77.45%   -0.08%     
==========================================
  Files          87       87              
  Lines        9294     9358      +64     
==========================================
+ Hits         7205     7248      +43     
- Misses       1654     1680      +26     
+ Partials      435      430       -5     
Flag Coverage Δ
go 79.19% <34.21%> (-0.10%) ⬇️
wasm 70.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cnderrauber
Copy link
Member

Thank you for refining this, can you add a test case for this?

@zjzhang-cn
Copy link
Member Author

zjzhang-cn commented Mar 3, 2023

Client peer cooperation is required.

@Sean-Der
Copy link
Member

Hey @zjzhang-cn thank you so much for the contribution!

Since this isn't a webrtc-pc API I don't believe merging it is the right thing to do. If a user wants to re-use a Transceiver they should find an inactive Transceiver and call ReplaceTrack I believe?

If I am wrong please re-open! I would love to see Pion be as good as possible.

thank you

@Sean-Der Sean-Der closed this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants