Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that NULL Protection Profile is disabled #2939

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Test that NULL Protection Profile is disabled #2939

merged 1 commit into from
Oct 28, 2024

Conversation

Sean-Der
Copy link
Member

Resolves pion/srtp#297

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.69%. Comparing base (271ab55) to head (974dadc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2939      +/-   ##
==========================================
- Coverage   79.01%   77.69%   -1.33%     
==========================================
  Files          89       89              
  Lines        8584    10462    +1878     
==========================================
+ Hits         6783     8128    +1345     
- Misses       1311     1845     +534     
+ Partials      490      489       -1     
Flag Coverage Δ
go 79.25% <ø> (-1.31%) ⬇️
wasm 63.56% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der Sean-Der merged commit ae89317 into master Oct 28, 2024
18 checks passed
@Sean-Der Sean-Der deleted the issue-297 branch October 28, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Please ensure that NULL profiles are not negotiated by default
1 participant