Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.vscode: Add launch settings for VS Code #5209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pcercuei
Copy link
Contributor

With this, it is now possible to launch Pioneer directly from VS Code on
Windows by simply pressing F5.

Signed-off-by: Paul Cercueil [email protected]

With this, it is now possible to launch Pioneer directly from VS Code on
Windows.

Signed-off-by: Paul Cercueil <[email protected]>
@sturnclaw
Copy link
Member

I like this idea on the surface, but I'm very hesitant to merge it if there's a possibility it will cause issues or confusion for other contributors. For example, I use VScode as well and have a decent amount of settings related to my personal workflow in the VScode config files; tracking these files in source control has the potential to turn into a constant stream of overwrite commits when submitting otherwise unrelated work.

I'd much prefer a setup script that creates the initial VScode files for a specific platform and leave these files untracked; I think this would be much more flexible and allow developers to tailor their launch options etc. to their liking without having to constantly preserve them from being overwritten.

@impaktor
Copy link
Member

If we don't want it in master, it could be offered as a downloadable on the wiki under development section, or somewhere else?

@pcercuei
Copy link
Contributor Author

pcercuei commented Jun 16, 2021

@Web-eWorks well, if your local launch.json rules are useful, why not add them here? Having several launch options is better than having none.

@impaktor
Copy link
Member

impaktor commented Nov 2, 2023

So in summary: Either we close (and potentially add note to dev docs), or add more useful stuff for pioneer dev in launch.json. It's up to @Web-eWorks . I see the point in not wanting local launch.json clobbered (Does VSCode support mulitple launch.json files?).

@sturnclaw
Copy link
Member

I consider this PR to be superseded with the merge of #5626. VSCode implicitly merges launch definition lists from the .code-workspace file as well as launch.json, but defaults to creating new configurations in the latter. That makes the launch.json file a better fit to be excluded from source control as it's for user-specific configurations which we do not want to be checking into source control.

If @pcercuei can determine the above configurations are still relevant with the changes to CMake management in VSCode, I'd welcome a PR to add them to the launch section of the optional pioneer-default.code-workspace file we now provide as a "quickstart" method for VSCode users. The quickstart method is fully documented in COMPILING.txt - you're welcome to copy / document in the dev docs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants