-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.vscode: Add launch settings for VS Code #5209
base: master
Are you sure you want to change the base?
Conversation
With this, it is now possible to launch Pioneer directly from VS Code on Windows. Signed-off-by: Paul Cercueil <[email protected]>
I like this idea on the surface, but I'm very hesitant to merge it if there's a possibility it will cause issues or confusion for other contributors. For example, I use VScode as well and have a decent amount of settings related to my personal workflow in the VScode config files; tracking these files in source control has the potential to turn into a constant stream of overwrite commits when submitting otherwise unrelated work. I'd much prefer a setup script that creates the initial VScode files for a specific platform and leave these files untracked; I think this would be much more flexible and allow developers to tailor their launch options etc. to their liking without having to constantly preserve them from being overwritten. |
If we don't want it in master, it could be offered as a downloadable on the wiki under development section, or somewhere else? |
@Web-eWorks well, if your local |
876b6fc
to
b5bc47c
Compare
90e4530
to
6a3a044
Compare
So in summary: Either we close (and potentially add note to dev docs), or add more useful stuff for pioneer dev in |
I consider this PR to be superseded with the merge of #5626. VSCode implicitly merges launch definition lists from the If @pcercuei can determine the above configurations are still relevant with the changes to CMake management in VSCode, I'd welcome a PR to add them to the launch section of the optional |
With this, it is now possible to launch Pioneer directly from VS Code on
Windows by simply pressing F5.
Signed-off-by: Paul Cercueil [email protected]