Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable runtime floating point exceptions #5610

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

sturnclaw
Copy link
Member

Clang 15+ / GCC 13+ leave us no choice but to disable floating point exceptions. Their auto-vectorization optimizations load invalid values and will cause FPEs even when fp-strict is enabled.

Reference #5601.

@d3rp please confirm this PR fixes the issue on GCC 13.

Clang 15+ / GCC 13+ leave us no choice but to disable floating point exceptions.
Their auto-vectorization optimizations load invalid values and will cause FPEs even when fp-strict is enabled.
@impaktor
Copy link
Member

I guess we could also reference:
llvm/llvm-project#63708

@d3rp
Copy link
Contributor

d3rp commented Aug 26, 2023

I built this PR on g++-12, g++-13 and clang++ (15.0.7) and all of them could start from Mars without crashing. Crashing was the result of the previous bug. Seems good to me!

There was an intermittent bug on the UI that shows the starting details after pressing "New Game". The starting cash and name were positioned on top of each other, but I couldn't replicate this. It is probably due to the design of drawing stuff in the upper left corner and repositioning them on their supposed positions, as that behavior shows as a quick flicker upon opening the scene (pressing "New Game")

@zonkmachine
Copy link
Member

There was an intermittent bug on the UI that shows the starting details after pressing "New Game". The starting cash and name were positioned on top of each other, but I couldn't replicate this

This is fixed in #5612

@d3rp
Copy link
Contributor

d3rp commented Aug 26, 2023

Btw, I'm not sure if it's connected or it is a previously creeped in bug, but starting the game with --start-at a.k.a. -sa will crash on my system.

On a debug build (g++-12) the culprit seems to be UpdateStarSystemCache and the assert hits a nullptr for sec.

As -sa skips all intros and jumps straight to Mars, I guess at some point the initiation routine got changed and the calls are in wrong order.

@zonkmachine
Copy link
Member

Btw, I'm not sure if it's connected or it is a previously creeped in bug, but starting the game with --start-at a.k.a. -sa will crash on my system.

Reported here: #5285 😉

@d3rp
Copy link
Contributor

d3rp commented Aug 26, 2023

Reported here: #5285 😉

Thanks - though the cause of the issue is different. I'll paste my findings there and continue on that thread.

@sturnclaw sturnclaw merged commit 422dbfe into pioneerspacesim:master Aug 26, 2023
@sturnclaw sturnclaw deleted the disable-fpe branch August 26, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants