Liskov Substitution Principle (LSP) #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TomasVotruba What do you think about this example? Is it not too complicated? I want to add two more examples later with a violation of LSP so that readers can see different methods of breach of contract. |
|
I got lost in changes and the original example as well. I don't have more free time to check this. @jupeter needs to review |
|
@TomasVotruba You can see changes in split mode. Perhaps this will be easier to read. |
|
Still too complicated for me I think it can be as simple as 15 lines of code (after few secs of Googling): https://www.tomdalling.com/blog/software-design/solid-class-design-the-liskov-substitution-principle/ |
|
I understood you. I will make an easier example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #37, #46
Correct Good example of LSP and add one more example.