-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTVI 0.2.0 #5
RTVI 0.2.0 #5
Conversation
@@ -0,0 +1,25 @@ | |||
# 0.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's probably some stuff missing from this changelog, I'll go through one more time and check but if you notice anything please let me know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I still need to add the version number in the initial request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, we were really missing a changelog file. I will add one on iOS as well.
*/ | ||
data class VoiceClientOptions( | ||
data class RTVIClientOptions( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we create an alias to mark VoiceClientOptions
as deprecated ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that we are already doing this in a different file. Cool!
package ai.rtvi.client | ||
|
||
|
||
@Deprecated("VoiceClient is renamed to RTVIClient") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I think I had added a comment somewhere else if we should add these alias.
It makes sense to keep in its own file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
No description provided.