Rename rtvi-client-android to pipecat-client-android #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aconchillo
reviewed
Dec 10, 2024
| @@ -53,7 +53,7 @@ private const val RTVI_PROTOCOL_VERSION = "0.2.0" | |||
| * @param options Additional options for configuring the client and backend. | |||
| */ | |||
| @Suppress("unused") | |||
| open class RTVIClient( | |||
| open class PipecatClient( | |||
There was a problem hiding this comment.
I believe we are keeping RTVIClient in other platforms.
There was a problem hiding this comment.
Yeah, I made the changes before seeing Mark's comment in the Slack thread. Will change this back tomorrow morning.
aconchillo
reviewed
Dec 10, 2024
| @@ -345,7 +345,7 @@ open class RTVIClient( | |||
| throw RTVIException(RTVIError.OtherError("Helper targeting service '$service' already registered")) | |||
| } | |||
|
|
|||
| helper.registerVoiceClient(RegisteredRTVIClient(this, service)) | |||
| helper.registerVoiceClient(RegisteredPipecatClient(this, service)) | |||
kompfner
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.