Simplify the static flows API #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aconchillo
reviewed
Dec 17, 2024
src/pipecat_flows/manager.py
Outdated
| logger.warning("Initial messages ignored for static flow configuration") | ||
|
|
||
| # Set initial system message if present | ||
| if hasattr(self, "initial_system_message"): |
There was a problem hiding this comment.
I think this could be:
if self.initial_system_message:
We should always have things (i.e. fields) defined, because this is kind of hiding what fields are defined or not depending on something else.
aconchillo
reviewed
Dec 17, 2024
| @@ -155,6 +97,7 @@ def __init__( | |||
| if flow_config: | |||
| self.nodes = flow_config["nodes"] | |||
| self.initial_node = flow_config["initial_node"] | |||
| self.initial_system_message = flow_config.get("initial_system_message", []) | |||
| self.transition_callback = self._handle_static_transition | |||
| logger.debug("Initialized in static mode") | |||
| else: | |||
There was a problem hiding this comment.
in this else block we would have:
self.initial_system_message = None
|
LGTM! Just made a small comment easy to fix. |
aconchillo
approved these changes
Dec 17, 2024
markbackman
force-pushed
the
mb/simplify-static-flows
branch
from
c68cdd5 to
00f9be1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
initial_system_messagefield inFlowConfig, which allows setting aglobal system message for static flows.
Changed
setup in static flows.