Skip to content

Commit

Permalink
services: fix DailyTransport stop/cleanup ordering
Browse files Browse the repository at this point in the history
  • Loading branch information
aconchillo committed May 15, 2024
1 parent f6257a8 commit 86feb1e
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to **pipecat** will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Fixed

- Fixed `DailyInputTransport` and `DailyOutputTransport` stop/cleanup ordering.

## [0.0.13] - 2024-05-14

### Changed
Expand Down
8 changes: 4 additions & 4 deletions src/pipecat/transports/services/daily.py
Original file line number Diff line number Diff line change
Expand Up @@ -421,13 +421,13 @@ async def start(self):
await self._session.join()

async def stop(self):
await super().stop()
await self._session.leave()
await super().stop()

async def cleanup(self):
await super().cleanup()
self._camera_in_thread.join()
await self._session.cleanup()
await super().cleanup()

def vad_analyze(self, audio_frames: bytes) -> VADState:
return self._session.vad_analyze(audio_frames)
Expand Down Expand Up @@ -522,12 +522,12 @@ async def start(self):
await self._session.join()

async def stop(self):
await super().stop()
await self._session.leave()
await super().stop()

async def cleanup(self):
await super().cleanup()
await self._session.cleanup()
await super().cleanup()

def write_raw_audio_frames(self, frames: bytes):
self._session.write_raw_audio_frames(frames)
Expand Down

0 comments on commit 86feb1e

Please sign in to comment.