Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow transport exit to end a running pipeline #101

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

chadbailey59
Copy link
Contributor

If you use the DailyTransport and set the duration_minutes property, the bot will leave the room after that many minutes have elapsed, but the pipeline itself will still be running. This change allows the pipeline to stop running, so the python process can exit cleanly.

@aconchillo
Copy link
Contributor

LGTM but tests are failing.

@aconchillo
Copy link
Contributor

Weird error, re-running tests...

@aconchillo aconchillo merged commit 9e64de8 into main Apr 4, 2024
2 of 3 checks passed
@aconchillo aconchillo deleted the cb/bot-exit branch October 23, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants