user image frames and other updates #112
Conversation
aconchillo
force-pushed
the
user-image-frame
branch
from
6e39c29 to
25459d2
Compare
|
|
||
| @ transport.event_handler("on_first_other_participant_joined") | ||
| async def on_first_other_participant_joined(transport, participant): | ||
| transport.render_participant_video(participant["id"], color_format="RGB") |
There was a problem hiding this comment.
I was going to say "let's make RGB the default" but I see you already did that 👍
There was a problem hiding this comment.
yes, actually, since it's the default, let me remove this from here.
| curr_time = time.time() | ||
| prev_time = self._video_renderers[participant_id]["timestamp"] | ||
| diff_time = curr_time - prev_time | ||
| period = 1 / self._video_renderers[participant_id]["framerate"] |
There was a problem hiding this comment.
One thing I know we'll need eventually is an "only on demand" option instead of always setting a frame rate. My way of doing that was maybe a bit clunky but it worked well—by setting the frame rate to 0, the transport would never send frames automatically, but the pipeline could request a new image for a participant by sending a certain frame type (RequestUserImage or something). Can we add that back in a follow-up PR?
There was a problem hiding this comment.
ah, sure! makes sense!
aconchillo
force-pushed
the
user-image-frame
branch
from
25459d2 to
57aabea
Compare
No description provided.