OpenAI and Fireworks vision services #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aconchillo
reviewed
Apr 12, 2024
aconchillo
reviewed
Apr 12, 2024
aconchillo
reviewed
Apr 12, 2024
aconchillo
reviewed
Apr 12, 2024
aconchillo
reviewed
Apr 12, 2024
aconchillo
reviewed
Apr 12, 2024
aconchillo
reviewed
Apr 12, 2024
|
|
||
| else: | ||
| description = await self.run_vision(frame) | ||
| yield TextFrame(description) |
There was a problem hiding this comment.
shouldn't run_vision be async already?
There was a problem hiding this comment.
It is, but naming things is hard 😂 the way you implemented the run_vision method for moondream returns a string that you wrap in a text frame, but the the way the OpenAI module returns completions is an AsyncGenerator, so I needed another run_vision method. It's clunky but I'm out of ideas
There was a problem hiding this comment.
I think we should make Moondream return AsyncGenerator :-). I'll fix that tomorrow.
chadbailey59
force-pushed
the
cb/fireworks-vision
branch
from
e79fdea to
3255c7f
Compare
|
ok to close @chadbailey59 ? |
|
closing because this is stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might try to add Fireworks image gen support tomorrow, but we can also merge this as-is if we need to cut a release