Initial commit of Google Gemini LLM service. #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aconchillo
reviewed
May 17, 2024
macos-py3.10-requirements.txt
Outdated
| # | ||
| # This file is autogenerated by pip-compile with Python 3.10 | ||
| # This file is autogenerated by pip-compile with Python 3.11 |
There was a problem hiding this comment.
nit: I try to generate this with python 3.10 just to make sure it works there. on macos i do:
brew install [email protected]
python3.10 -m venv venv
...
...
pip-compile --all-extras pyproject.toml
mv requirements.txt macos-py3.10-requirements.txt
aconchillo
reviewed
May 17, 2024
src/pipecat/services/openai.py
Outdated
| del message["mime_type"] | ||
|
|
||
| # messages_for_log = json.dumps(messages) | ||
| # logger.debug(f"Generating chat: {messages_for_log}") |
aconchillo
approved these changes
May 17, 2024
Gemini text input works. We translate from OpenAILLMContext format on the fly in the GoogleLLMService implementation. This commit also implements image input (vision) in both the GoogleLLMService and in the OpenAILLMService. Image input is a hack and needs to be revisited. OpenAI expects images to be uploaded as base64-encoded JPEGs. Google does not require the base64 encoding. Other than for images, we use the OpenAI format as our standard, but base64-encoding the images and then unencoding them in the GoogleLLMService feels wasteful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gemini text input works. We translate from OpenAILLMContext format on the fly in the GoogleLLMService implementation.
This commit also implements image input (vision) in both the GoogleLLMService and in the OpenAILLMService. Image input is a hack and needs to be revisited. OpenAI expects images to be uploaded as base64-encoded JPEGs. Google does not require the base64 encoding. Other than for images, we use the OpenAI format as our standard, but base64-encoding the images and then unencoding them in the GoogleLLMService feels wasteful.