Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processors: fix LLMResponseAggregator with lower VAD values #223

Merged
merged 1 commit into from
Jun 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Fixed an issue that would cause LLM aggregator to fail with small
`VADParams.stop_secs` values.

- Fixed an issue where `BaseOutputTransport` would send longer audio frames
preventing interruptions.

Expand Down
5 changes: 3 additions & 2 deletions src/pipecat/processors/aggregators/llm_response.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ def role(self):
# S I T E -> X
# S I E T -> X
# S I E I T -> X
#
# S E T -> X
# S E I T -> X
# The following case would not be supported:
#
# S I E T1 I T2 -> X
Expand All @@ -96,7 +97,7 @@ async def process_frame(self, frame: Frame, direction: FrameDirection):
# We might have received the end frame but we might still be
# aggregating (i.e. we have seen interim results but not the final
# text).
self._aggregating = self._seen_interim_results
self._aggregating = self._seen_interim_results or len(self._aggregation) == 0

# Send the aggregation if we are not aggregating anymore (i.e. no
# more interim results received).
Expand Down
Loading