Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug and optimize keepalive #488

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix bug and optimize keepalive #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/pipecat/services/elevenlabs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import asyncio
import base64
import json
import time

from typing import Any, AsyncGenerator, List, Literal, Mapping, Tuple
from pydantic import BaseModel
Expand Down Expand Up @@ -117,6 +118,7 @@ def __init__(
# there's an interruption or TTSStoppedFrame.
self._started = False
self._cumulative_time = 0
self._last_message_time = 0

def can_generate_metrics(self) -> bool:
return True
Expand All @@ -134,8 +136,9 @@ async def set_voice(self, voice: str):
await self._connect()

async def start(self, frame: StartFrame):
await super().start(frame)
await self._connect()
if not (self._websocket and self._websocket.open):
await super().start(frame)
await self._connect()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this anymore. StartFrame is now guaranteed to arrive first to all frames. So the self._connect() should happen before any other frame is received.


async def stop(self, frame: EndFrame):
await super().stop(frame)
Expand Down Expand Up @@ -225,7 +228,9 @@ async def _keepalive_task_handler(self):
while True:
try:
await asyncio.sleep(10)
await self._send_text("")
current_time = time.time()
if current_time - self._last_message_time >= 10:
await self._send_text("")
Copy link
Contributor

@aconchillo aconchillo Oct 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update self._last_message_time otherwise we could send keepalives continuously.

except asyncio.CancelledError:
break
except Exception as e:
Expand All @@ -235,6 +240,7 @@ async def _send_text(self, text: str):
if self._websocket:
msg = {"text": text + " "}
await self._websocket.send(json.dumps(msg))
self._last_message_time = time.time()

async def run_tts(self, text: str) -> AsyncGenerator[Frame, None]:
logger.debug(f"Generating TTS: [{text}]")
Expand Down
Loading