add calls to flush_audio for say() and rtvi action #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aconchillo
reviewed
Sep 23, 2024
src/pipecat/services/ai_services.py
Outdated
| @@ -186,6 +186,7 @@ async def run_tts(self, text: str) -> AsyncGenerator[Frame, None]: | |||
|
|
|||
| async def say(self, text: str): | |||
| await self.process_frame(TextFrame(text=text), FrameDirection.DOWNSTREAM) | |||
| await self.flush_audio() | |||
There was a problem hiding this comment.
flush_audio is only available in AsynTTSService since I thought it only made sense there. We have two options:
- Add
flush_audiotoTTSService - Override
say()inAsyncTTSServicewith
async def say(self, text: str):
super().say(text)
await self.flush_audio()
There was a problem hiding this comment.
I don't think there's anything to flush in TTSService, so maybe option 2 is better?
aconchillo
reviewed
Sep 23, 2024
src/pipecat/services/ai_services.py
Outdated
| @@ -235,6 +236,7 @@ async def process_frame(self, frame: Frame, direction: FrameDirection): | |||
| await self.push_frame(frame, direction) | |||
| elif isinstance(frame, TTSSpeakFrame): | |||
| await self._push_tts_frames(frame.text) | |||
| await self.flush_audio() | |||
There was a problem hiding this comment.
Same here.
async def process_frame(self, frame: Frame, direction: FrameDirection):
super().process_frame(frame, direction)
if isinstance(frame, TTSSpeakFrame):
await self.flush_audio()
There was a problem hiding this comment.
This should be await super().process_frame(frame, direction), right?
(An await in front of the call to the super class's method.)
kwindla
force-pushed
the
khk/flush-more-audio
branch
from
cb11b6f to
3621fce
Compare
aconchillo
reviewed
Sep 25, 2024
src/pipecat/services/ai_services.py
Outdated
| @@ -278,6 +282,11 @@ async def cancel(self, frame: CancelFrame): | |||
| await self._stop_frame_task | |||
| self._stop_frame_task = None | |||
|
|
|||
| async def process_frame(self, frame: Frame, direction: FrameDirection): | |||
| super().process_frame(frame, direction) | |||
There was a problem hiding this comment.
We are still missing the await here.
There was a problem hiding this comment.
Egads. Sorry. I clearly do not know how to use computers.
aconchillo
approved these changes
Sep 25, 2024
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
flush_audio()after direct calls to TTSsay()and when processingTTSSpeakFrames.