Add an app message to the translator starter app #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moishe
reviewed
Mar 18, 2024
Moishe
reviewed
Mar 19, 2024
| image: bytes | ||
|
|
||
| def __str__(self): | ||
| return f"{self.__class__.__name__}, participantId: {self.participantId}, image size: {len(self.image)} B" |
There was a problem hiding this comment.
should this guard that self.image is not None?
| image: bytes | ||
|
|
||
| def __str__(self): | ||
| return f"{self.__class__.__name__}, prompt: {self.prompt}, image size: {len(self.image)} B" |
| pass | ||
|
|
||
| async def process_frame(self, frame: Frame) -> AsyncGenerator[Frame, None]: | ||
| if isinstance(frame, VisionFrame): |
There was a problem hiding this comment.
I think this should pass-through non-VisionFrame frames.
| def _handle_video_frame(self, participant_id, video_frame): | ||
| # TODO-CB: What about multiple participants? | ||
| if (not participant_id in self._participant_frame_times) or (time.time() > self._participant_frame_times[participant_id] + 1.0/self._receive_video_fps): | ||
| print(f"### sending frame now") |
There was a problem hiding this comment.
could change this to logger.debug
| if (not participant_id in self._participant_frame_times) or (time.time() > self._participant_frame_times[participant_id] + 1.0/self._receive_video_fps): | ||
| print(f"### sending frame now") | ||
| self._participant_frame_times[participant_id] = time.time() | ||
| asyncio.run_coroutine_threadsafe( |
There was a problem hiding this comment.
might be worth assigning the result of this to a variable (eg future), then calling future.result()
| ) | ||
| ) | ||
| async for chunk in chunks: | ||
| print(f"!!! chunk: {chunk}") |
|
This PR is obsolete, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.