Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Fish Audio tts #827

Closed
wants to merge 6 commits into from

Conversation

MoeMamdouh
Copy link

@MoeMamdouh MoeMamdouh commented Dec 11, 2024

Add FishAudioTTSService for real-time TTS processing via WebSocket

@@ -33,7 +33,7 @@
RTVIBotTranscriptionProcessor,
RTVIUserTranscriptionProcessor,
)
from pipecat.services.elevenlabs import ElevenLabsTTSService
from pipecat.services.fish import FishAudioTTSService
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of changing the example, please add a foundational example that is a minimal test case. You should mimic and one of the 07* foundational examples (e.g. https://github.com/pipecat-ai/pipecat/blob/main/examples/foundational/07d-interruptible-elevenlabs.py)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MoeMamdouh MoeMamdouh changed the title feat(fish): add FishAudioTTSService for real-time TTS processing via … Support Fish Audio tts Dec 19, 2024
@aconchillo
Copy link
Contributor

@MoeMamdouh Do you mind fixing the formatting issues? Take a look at https://github.com/pipecat-ai/pipecat?tab=readme-ov-file#setting-up-your-editor to setup your editor.

@markbackman
Copy link
Contributor

@MoeMamdouh I ran this and hit two issues:

  1. There is popping at the start of each phrase
  2. The last phrase is not being returned from Fish

The first issue can be resolved but the second seems like a Fish Audio issue. Have you noticed this and/or found a fix.

FYI: I started a parallel branch for this that confirms a bit better to the Pipecat TTS style: #899. We'll probably close this one out and work on the other, but before I do so, I want to see if you've resolved issue #294

(In the PR I posted, I was able to solve the popping issue by filtering on size. There may be a better way, but for now, it's fine.)

@markbackman
Copy link
Contributor

@MoeMamdouh I got a response from the Fish team and resolved the issue. I'm going to close this PR and we'll use #899 instead. Thanks so much for helping to get this started. I hope this service works well for you.

@MoeMamdouh
Copy link
Author

@MoeMamdouh I got a response from the Fish team and resolved the issue. I'm going to close this PR and we'll use #899 instead. Thanks so much for helping to get this started. I hope this service works well for you.

thank you @markbackman You are welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants