Remove default 5 min exp time for created rooms, add docstrings #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aconchillo
approved these changes
Dec 13, 2024
|
LGTM |
|
Missing CHANGELOG |
markbackman
force-pushed
the
mb/daily-rest-helpers
branch
from
bf2e44d to
16d7fb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
Someone in Discord mentioned being puzzled by the 5 min room expiration time. This exp time does seem to get in the way and is unexpected.
For now, I've removed the exp default, setting exp to
Optionaland a default ofNone. Alternatively, we could raise the value to a higher time, like 1 hr. That way rooms would be automatically deleted.Also, added docstrings.