Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services: fix infinite websocket-bases TTS services retries #872

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

aconchillo
Copy link
Contributor

@aconchillo aconchillo commented Dec 16, 2024

Please describe the changes in your PR. If it is addressing an issue, please reference that as well.

This fix uses tenacity to implement limited retries with an exponential backoff for websocket-based TTS services.

Fixes #871

@aconchillo aconchillo changed the base branch from main to pipecat-0.0.50 December 16, 2024 23:09
@aconchillo aconchillo force-pushed the aleix/fix-871-infinite-tts-retries branch from 96731c4 to 653fbb7 Compare December 16, 2024 23:14
Copy link
Contributor

@markbackman markbackman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix!

@aconchillo aconchillo merged commit 8b8c22c into pipecat-0.0.50 Dec 16, 2024
3 of 4 checks passed
@aconchillo aconchillo deleted the aleix/fix-871-infinite-tts-retries branch December 16, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cartesia websocket infinite retires with no backoff
2 participants