Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services(nim): fix function call #876

Closed
wants to merge 1 commit into from
Closed

Conversation

vipyne
Copy link
Member

@vipyne vipyne commented Dec 17, 2024

Please describe the changes in your PR. If it is addressing an issue, please reference that as well.

function calling with NIM (examples/foundational/14j-function-calling-nim.py) gives the error:

2024-12-16 22:51:02.205 | ERROR    | pipecat.pipeline.task:_handle_upstream_frame:64 - Error running app: ErrorFrame#0(error: Error code: 400 - {'type': 'about:blank', 'status': 400, 'title': 'Bad Request', 'detail': "[{'type': 'string_too_short', 'loc': ('body', 'messages', 5, 'content'), 'msg': 'String should have at least 1 character', 'input': '', 'ctx': {'min_length': 1}}]"}, fatal: False)

I tracked it down to this line.

there may be a more elegant way to solve this, but this PR does the trick for me.

@markbackman
Copy link
Contributor

markbackman commented Dec 17, 2024

@vipyne rather than change NimLLMService due to a Grok requirement, let's update the GrokLLMService. I've made that change here: #877.

In that PR, I made the example changes you've recommended here.

@vipyne
Copy link
Member Author

vipyne commented Dec 17, 2024

closed in favor of #877

@vipyne vipyne closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants