Server updates #90
Merged
Server updates #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've refactored the server quite a bit to add some functionality. I'll add better deploy options (Docker, Heroku button, etc) in a follow-up. |
Moishe
approved these changes
Mar 28, 2024
examples/server/daily-bot-manager.py
Outdated
|
|
||
| @app.route("/start/<string:text>", methods=["GET", "POST"]) | ||
| def start(text): | ||
| if text in APPS: |
There was a problem hiding this comment.
nitpick: might be easier to read (or at least less indentation) if you check if text not in APPS and then immediately raise an exception.
chadbailey59
added a commit
that referenced
this pull request
Apr 2, 2024
* updated server readme * fixup * Refactored server * fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the server ready for the hackathon, etc.