Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transports(base_output): fix duplicate push_frame() #906

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

aconchillo
Copy link
Contributor

Please describe the changes in your PR. If it is addressing an issue, please reference that as well.

@aconchillo
Copy link
Contributor Author

The problem was that _sink_frame_handler() was calling push_frame() and we were also calling push_frame() from _sink_task_handler(). So we don't need to do it in sink_frame_handler(). sink_frame_handler() only performs something on a frame if there's something to do. If you want to push a frame, so push it later.

@aconchillo aconchillo force-pushed the aleix/fix-duplicate-base-output-frames branch from 1d4bab5 to c04c69d Compare December 22, 2024 22:43
Copy link
Contributor

@markbackman markbackman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That solves the issue for me!

@aconchillo aconchillo merged commit cd7dec7 into main Dec 23, 2024
4 checks passed
@aconchillo aconchillo deleted the aleix/fix-duplicate-base-output-frames branch December 23, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants