Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: push input audio frame only via push_audio_frame() #959

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KevGTL
Copy link

@KevGTL KevGTL commented Jan 10, 2025

Resolves #958.

In LiveKit transport, when handling audio input, push audio frames only with push_audio_frame() and remove the additional call to push_frame().

I noticed it was handled this way in other transports:

  • in DailyInputTransport (only one call to push_audio_frame())
  • in FastApiWebsocketInputTransport(push audio frames with push_audio_frame(), others with push_frame())
  • etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Livekit transport error on audio in
1 participant