Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies (go back to numpy1) #997

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

aconchillo
Copy link
Contributor

Please describe the changes in your PR. If it is addressing an issue, please reference that as well.

Fixes #911, #913

@aconchillo aconchillo force-pushed the aleix/update-dependencies-01-15-25 branch from 15ef807 to af7930e Compare January 15, 2025 20:02
@aconchillo aconchillo force-pushed the aleix/update-dependencies-01-15-25 branch from af7930e to 4de192f Compare January 15, 2025 20:04
playht = [ "pyht~=0.1.9", "websockets~=13.1" ]
openai = [ "openai~=1.59.6", "websockets~=13.1", "python-deepcompare~=2.1.0" ]
openpipe = [ "openpipe~=4.43.0" ]
playht = [ "pyht~=0.1.6", "websockets~=13.1" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this version rolling back?

assemblyai = [ "assemblyai~=0.34.0" ]
aws = [ "boto3~=1.35.27" ]
azure = [ "azure-cognitiveservices-speech~=1.41.1", "openai~=1.59.0" ]
anthropic = [ "anthropic~=0.39.0" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Why is this version rolling back?

@aconchillo
Copy link
Contributor Author

The rollbacks are so you can install ALL pipecat dependencies without conflicts. With this PR you can now do the following without any issues and all of the examples work.

pip install -e ".[anthropic,assemblyai,aws,azure,canonical,cartesia,cerebras,deepseek,daily,deepgram,elevenlabs,fal,fish,gladia,google,grok,groq,gstreamer,fireworks,koala,langchain,livekit,lmnt,local,moondream,nim,noisereduce,openai,openpipe,openrouter,playht,riva,silero,simli,soundfile,together,websocket,whisper]"

@aconchillo
Copy link
Contributor Author

I believe we should be able to install all of them side by side without any issues.

@aconchillo
Copy link
Contributor Author

Also, developers can pin a newer version if they want to for any package. That is, they could have conflicts if they installed everything but maybe they are only interested in, let's say, anthropic so they could just update to latest in their environment.

Copy link
Contributor

@markbackman markbackman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I figured that was the case.

LGTM

@aconchillo aconchillo merged commit bb47664 into main Jan 15, 2025
4 checks passed
@aconchillo aconchillo deleted the aleix/update-dependencies-01-15-25 branch January 15, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_base_client.py file passess wrong argument in to AsyncHttpxClientWrapper
2 participants