Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(contracts): various fixes for audit issues #380

Merged
merged 9 commits into from
Dec 13, 2024
Merged

fix(contracts): various fixes for audit issues #380

merged 9 commits into from
Dec 13, 2024

Conversation

Ramarti
Copy link
Contributor

@Ramarti Ramarti commented Nov 26, 2024 •
edited
Loading

  • TRST-R-13: Remove unused Predeploys.isPredeploy() and isActivePredeploy()
  • TRST-R-14 Update the documentation around the WIP token deployment and predeploy namespaces
  • TRST-R-4 Check zero amounts after the rounding in IPTokenStaking contract
  • TRST-L-1 Lack of UBI token distribution segregation might prevent validators from claiming their entitled rewards

issue: none

@Ramarti Ramarti changed the title fix(contracts): various fixes for Trust's audit issues fix(contracts): various fixes for audit issues Nov 27, 2024
@Ramarti Ramarti marked this pull request as ready for review November 27, 2024 20:36
@Ramarti Ramarti force-pushed the trust-contract-fixes branch from 90d31b1 to 2c1c936 Compare November 27, 2024 21:56
0xHansLee
0xHansLee approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please regenerate bindings as well before merging.

@limengformal
Copy link
Contributor

limengformal commented Dec 6, 2024 •
edited
Loading

As discussed with @edisonz0718 , we will not fix #393 in odyssey since it is a name change. We will apply the fix in mainnet version.

Let's not merge for now

@Ramarti Ramarti force-pushed the trust-contract-fixes branch from dc7d407 to 7844676 Compare December 13, 2024 00:54
@Ramarti Ramarti force-pushed the trust-contract-fixes branch from 7844676 to 62b7975 Compare December 13, 2024 01:16
@Ramarti Ramarti merged commit 2b180d7 into main Dec 13, 2024
8 checks passed
@Ramarti Ramarti deleted the trust-contract-fixes branch December 13, 2024 01:21
@github-actions GitHub Actions
Copy link

Binary uploaded successfully 🎉

📦 Version Name: 0.14.1-unstable-2b180d7
📦 Download Source: AWS S3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoHChen LeoHChen Awaiting requested review from LeoHChen LeoHChen is a code owner

@AndyBoWu AndyBoWu Awaiting requested review from AndyBoWu AndyBoWu is a code owner

@edisonz0718 edisonz0718 Awaiting requested review from edisonz0718 edisonz0718 is a code owner

@ezreal1997 ezreal1997 Awaiting requested review from ezreal1997 ezreal1997 is a code owner

@limengformal limengformal Awaiting requested review from limengformal limengformal is a code owner

@leeren leeren Awaiting requested review from leeren leeren is a code owner

@0xHansLee 0xHansLee Awaiting requested review from 0xHansLee 0xHansLee is a code owner

@jdubpark jdubpark Awaiting requested review from jdubpark jdubpark is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ramarti @limengformal @jdubpark @0xHansLee