Issue33: pickle mem leak #41
Conversation
Fixes memory leaking of objects when pickling.
| @@ -393,7 +393,7 @@ CMS_VARIANT(_reduce)(CMS_TYPE *self) | |||
| return NULL; | |||
| PyList_SetItem(state_table, self->depth, hll); | |||
| PyList_SetItem(state_table, self->depth + 1, Py_BuildValue("i", self->total)); | |||
| return Py_BuildValue("(OOO)", Py_TYPE(self), args, state_table); | |||
| return Py_BuildValue("(ONN)", Py_TYPE(self), args, state_table); | |||
There was a problem hiding this comment.
"O" further increases reference count, causing memory leak. "N" is the same as "O" but does not increase reference counts.
|
@menshikh-iv Py3.3 should be removed from CI, the required image is no longer present |
|
@isamaru Can you please merge master into this PR? That should take care of the CI problem. |
|
We can't merge this until the tests pass. I was hoping that @isamaru can take care of that. |
|
Looks like Python 3.3 is no longer available for CI. |
|
Hello. Just wanted to do a ping regarding this PR. Thank you in advance. |
|
Thanks for bumping this @jonsnowseven. @mpenkov if OK, can you merge & release please? |
|
@isamaru Thank you for the contribution. @piskvorky and @jonsnowseven Thank you for the reminders, finally got around to taking care of this. |
Solves #33