Skip to content

Commit

Permalink
Merge pull request #172 from pittcsc/171-people-tests-mock
Browse files Browse the repository at this point in the history
verified mock test data works + changed test a bit to be resistent
  • Loading branch information
nij-patel authored May 23, 2024
2 parents 848027c + 98ce94e commit 38cf761
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions tests/people_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ def test_people_get_person(self):

ans = people.get_person("John C Ramirez")
self.assertIsInstance(ans, list)
self.assertTrue(ans[0]['email'] == "[email protected]")
self.assertTrue(ans[0]['name'] == "Ramirez, John C")
self.assertTrue(ans[0]['office_phone'] == "(412) 624-8441")

Expand All @@ -135,6 +134,6 @@ def test_people_get_person_none(self):
responses.add(responses.POST, people.PEOPLE_SEARCH_URL,
body=NONE_FOUND_TEST_DATA, status=200)

ans = people.get_person("Lebron Iverson Jordan Kobe")
ans = people.get_person("Lebron Iverson James Jordan Kobe")
self.assertIsInstance(ans,list)
self.assertEqual(ans, [{"ERROR":"No one found."}])

0 comments on commit 38cf761

Please sign in to comment.