-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: [FEATURE] Coupon codes #166
Open
mabolek
wants to merge
71
commits into
TYPO3_8
Choose a base branch
from
165-add-discount-codes
base: TYPO3_8
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@vuxorpadd - I requested a review from you. This is just the framework, not a mergeable version, but I'd love feedback from you on this work in progress. |
Returns the quantity of a specific product in the order based on the supplied Product object.
Formats a value according to the lowest currency value, so €1.50 becomes the integer 150.
[TASK] Move FE price calculation to Backend
…uct_manager into 165-add-discount-codes
Checking for product by UID rather than Object works best.
Rewrite subscriptions
[TASK] Fix totatl price formatting
Fix wishlist counters
Fix total price recalculation
[TASK] Make subscription getter return subscription record
[TASK] Fix order duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e. discount codes. Fixes #165