fix: Fix combineSkeletons, collectSkinIndexAttrs

The continue statement is not working as intended

I also forgot to set the new attribute when we found an already registered skin index attribute

I had to change eslint `@typescript-eslint/naming-convention` rule in order to use `_` for parameter names

.eslintrc.json

@@ -27,7 +27,7 @@
         "format": ["camelCase"]
       },
       {
-        "selector": "variable",
+        "selector": "variableLike",
         "format": ["camelCase", "UPPER_CASE"],
         "leadingUnderscore": "allow"
       },

packages/three-vrm/src/VRMUtils/combineSkeletons.ts

@@ -265,7 +265,7 @@ function collectSkinIndexAttrs(
   >();
 
   for (const mesh of meshes) {
-    let skinIndexAttr = mesh.geometry.getAttribute('skinIndex');
+    const skinIndexAttr = mesh.geometry.getAttribute('skinIndex');
 
     // Get or create a map for the skin index attribute
     let newSkinIndexBonesMap = skinIndexNewSkinIndexBonesMapMap.get(skinIndexAttr);
@@ -279,17 +279,19 @@ function collectSkinIndexAttrs(
     }
 
     // Check if the bone set is already registered
-    for (const bones of newSkinIndexBonesMap.values()) {
-      if (arrayEquals(bones, mesh.skeleton.bones)) {
-        continue;
-      }
+    // If the bone set is already registered, reuse the skin index attribute
+    let newSkinIndexAttr = Array.from(newSkinIndexBonesMap).find(([_, bones]) =>
+      arrayEquals(bones, mesh.skeleton.bones),
+    )?.[0];
+
+    // If there is no matching bone set, clone the skin index attribute
+    if (newSkinIndexAttr == null) {
+      newSkinIndexAttr = skinIndexAttr.clone();
+      newSkinIndexBonesMap.set(newSkinIndexAttr, mesh.skeleton.bones);
+      skinIndexBonesPairSet.add([newSkinIndexAttr, mesh.skeleton.bones]);
     }
 
-    // There is no matching bone set, so clone the skin index attribute
-    skinIndexAttr = skinIndexAttr.clone();
     mesh.geometry.setAttribute('skinIndex', skinIndexAttr);
-    newSkinIndexBonesMap.set(skinIndexAttr, mesh.skeleton.bones);
-    skinIndexBonesPairSet.add([skinIndexAttr, mesh.skeleton.bones]);
   }
 
   return skinIndexBonesPairSet;