Skip to content

Commit

Permalink
fall thru to tcp/ip for any AF_UNIX/ipc error
Browse files Browse the repository at this point in the history
zeromq/pyzmq#1505
a few Jupyter users have encountered an issue where there program ends after this assert:
Bad file descriptor (C:\ci\zeromq_1602704446950\work\src\epoll.cpp:100)

We found this happens for users that have a windows 10 build that supports AF_Unix sockets but does not for those who have older windows 10 builds.  this change is to remove the preserved errno (which doesn't appear to be used/checked anywhere-hence the later assert/abort) and instead after cleanup try to use a tcp/ip socket.
  • Loading branch information
pjaggi1 authored May 19, 2022
1 parent 37224c9 commit 177a9b9
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/ip.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -664,11 +664,10 @@ int zmq::make_fdpair (fd_t *r_, fd_t *w_)
}
filename.clear ();
}

/*
errno = saved_errno;

return -1;

*/
try_tcpip:
// try to fallback to TCP/IP
// TODO: maybe remember this decision permanently?
Expand Down

0 comments on commit 177a9b9

Please sign in to comment.