Patch music engine to avoid echo buffer overwriting sample data #292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we've become aware of a bug. When transitioning from a song with a non-zero echo delay value to a new song which uses instrument samples that would overlap with the previous echo buffer, the samples may become corrupted independent of the echo value used by the new song. This is because the echo feature was not disabled when the instruments for the new song were uploaded.
This branch adds a new feature where CoilSnake will patch the music engine to disable echo when uploading data.
This is the assembly code added to the SPC, assembled by hand: