Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce repetition by adding keychain functions to config struct #6

Closed
wants to merge 1 commit into from

Conversation

jhheider
Copy link

matter of taste. discard if not wanted.

@jhheider jhheider requested a review from mxcl November 27, 2024 22:29
Base automatically changed from contain-the-magic to main December 2, 2024 14:26
@mxcl
Copy link
Member

mxcl commented Dec 2, 2024

I dislike having the Config object not be a 1:1 mapping of the TOML and prefer the explicit fetch of sensitive data being clear. Though am not opposed to cleaning up the codebase in general, it's messy because I am over 40 and not OCD about code cleanliness anymore lol

@jhheider
Copy link
Author

jhheider commented Dec 2, 2024

Yes, it's all a matter of taste. In general, I like to implement actions as methods on their data, which is what this does. Still, perfectly easy and far from unheard of to have non-method functions. There's always the option of using a struct other than config to hold the in-memory representation.

@mxcl mxcl closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants