Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-configurable time format #240

Closed
cpinkham opened this issue Oct 10, 2023 · 3 comments
Closed

User-configurable time format #240

cpinkham opened this issue Oct 10, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@cpinkham
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I would like to have the ability to display a 12-hour time format without the AM/PM indicators to save space.

Describe the solution you'd like
I am looking for your preference on how to implement so I can submit a pull request. I can either allow generic strings like 'h:mm' in the current time_format field which would mean disabling the "must be '12' or '24'" sanity check in types.js or I can create a new optional time_format_str field which is a string type and doesn't have any sanity check in types.js.

Describe alternatives you've considered
I am currently running a patched version which enables this functionality using a new time_format_str field.

Additional context
Not much to show here:

time_format: h:mm

OR with a new field:

time_format_str: h:mm

@pkissling pkissling added the enhancement New feature or request label Oct 11, 2023
@pkissling
Copy link
Owner

i think it makes sense to introduce time_pattern property similar to date_pattern

@cpinkham
Copy link
Contributor Author

OK, thanks. I didn't even notice that date already supported something like this. I'll take a look at it and see about generating a pull request for time.

@pkissling
Copy link
Owner

Released 2.1.0 including #242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants