Add a new time_pattern option.

[cpinkham]

• Default new option value to 'HH:mm'
• Remove time_format fallbacks to locale and instead fall through to using time_pattern.
• time_format option can be removed when ready leaving time_pattern to act for time the same as date_pattern acts for date.

References #240

[pkissling]

thanks for the PR and your contribution. i requested some changes to make sure we don't breaking existing installations of clock-weather-card after updating to the version including your changes

[cpinkham]

I have all of these ready to add to a commit but have one question about the Full Configuration change before I update the pull request. Do you want it to be noted in any way in the Full Configuration section indicating time_pattern overrides time_format if both are provided?

Something like:

time_pattern: HH:mm
# Note: time_format is ignored if both time_pattern and time_format are provided
time_format: 24

Thanks for your feedback on this, this is my first time using TypeScript or contributing to HA, so it has been a slight learning curve.

[pkissling]

I have all of these ready to add to a commit but have one question about the Full Configuration change before I update the pull request. Do you want it to be noted in any way in the Full Configuration section indicating time_pattern overrides time_format if both are provided?

Something like:

time_pattern: HH:mm # Note: time_format is ignored if both time_pattern and time_format are provided time_format: 24

Thanks for your feedback on this, this is my first time using TypeScript or contributing to HA, so it has been a slight learning curve.

no problem, i'm glad your are contributing new features.
i think its sufficient if you mention it in the corresponding property description of https://github.com/pkissling/clock-weather-card#options

[pkissling]

thanks for your contribution!

[cpinkham]

Sorry, I hadn't commented again yet because I was going to see what I could do about that merge. I wanted a cleaner request without all the extra commits listed. Thanks for pulling this in.