light effect #20
Open
light effect #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkleczko
reviewed
Sep 29, 2018
| @@ -104,6 +111,13 @@ else if (mStrokeCap.equals("ROUND")) | |||
| mPoint = mStartAngle; | |||
| } | |||
|
|
|||
| public void setLightEffect(boolean mLightEffect) { | |||
| this.mLightEffectActive = mLightEffect; | |||
| if(mLightEffect){ | |||
There was a problem hiding this comment.
please reformat code (missing space here)
| @@ -127,7 +141,13 @@ protected void onDraw(Canvas canvas) { | |||
| mPaint.setShader(null); | |||
| canvas.drawArc(mRect, mStartAngle, mSweepAngle, false, mPaint); | |||
| mPaint.setColor(mPointStartColor); | |||
| mPaint.setShader(new LinearGradient(getWidth(), getHeight(), 0, 0, mPointEndColor, mPointStartColor, Shader.TileMode.CLAMP)); | |||
|
|
|||
| if(mLightEffectActive){ | |||
There was a problem hiding this comment.
please reformat code (missing space here)
| @@ -153,6 +173,7 @@ protected void onDraw(Canvas canvas) { | |||
| } | |||
| } | |||
|
|
|||
| if(mLightEffectActive) invalidate(); | |||
There was a problem hiding this comment.
please reformat code (missing space here); use braces for if conditions, even if its only one instruction, move it to new line
| private float mLightPosition = 0; | ||
| private float mLightMoveSpeed = .5f; | ||
| private List<Integer> mColorsRangeList = new ArrayList<>(); | ||
| // private Matrix matrix = new Matrix(); |
There was a problem hiding this comment.
remove comments if not necessary
| } | ||
|
|
||
|
|
||
|
|
| @@ -1,93 +1,11 @@ | |||
| CustomGauge | |||
| CustomGauge with light effect animation | |||
There was a problem hiding this comment.
Please just add new section about light effect animation at the bottom of README instead of removing its content and renaming lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi dear,
I just add a light effect to this component.